src/panels/config/integrations/integration-panels/thread/thread-config-panel.ts (1)

Line range hint 463-481: Specify a more accurate type than any for otbr.

Using any reduces type safety. Consider specifying a more accurate type for better type checking and maintainability.

- const otbr = (ev.currentTarget as any).otbr as OTBRInfo;
+ const otbr = (ev.currentTarget as HTMLElement).otbr as OTBRInfo;

Tools

Biome

[error] 472-472: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

---

[error] 487-487: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)

any disables many type checking rules. Its use should be avoided.

src/panels/config/integrations/integration-panels/thread/thread-config-panel.ts (4)

Line range hint 491-504: Improve error handling in _resetBorderRouter.

The method uses any for error handling, which reduces type safety. Consider specifying a more accurate type for the error and enhance error handling to manage specific error cases.

try {
  await OTBRCreateNetwork(this.hass, otbr.extended_address);
} catch (err: unknown) {
  showAlertDialog(this, {
    title: this.hass.localize("ui.panel.config.thread.otbr_config_failed"),
    text: (err as Error).message,
  });
  // Log error or handle specific error cases here
}

Tools

Biome

[error] 472-472: Forbidden non-null assertion. (lint/style/noNonNullAssertion)

---

[error] 487-487: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)

any disables many type checking rules. Its use should be avoided.

---

Line range hint 612-644: Improve error handling in _changeChannel.

The method uses any for error handling, which reduces type safety. Consider specifying a more accurate type for the error and enhance error handling to manage specific error cases.

try {
  const result = await OTBRSetChannel(this.hass, otbr.extended_address, channel);
  showAlertDialog(this, {
    title: this.hass.localize("ui.panel.config.thread.change_channel_initiated_title"),
    text: this.hass.localize("ui.panel.config.thread.change_channel_initiated_text", { delay: Math.floor(result.delay / 60) }),
  });
} catch (err: unknown) {
  if (err instanceof CustomError) { // Assume CustomError is a more specific error type you might expect
    showAlertDialog(this, {
      title: "Specific Error",
      text: err.message,
    });
  } else {
    showAlertDialog(this, {
      title: "Error",
      text: (err as Error).message,
    });
  }
}

---

Line range hint 514-533: Improve error handling in _setDataset.

The method uses any for error handling, which reduces type safety. Consider specifying a more accurate type for the error and enhance error handling to manage specific error cases.

try {
  await OTBRSetNetwork(this.hass, otbr.extended_address, preferedDatasetId);
} catch (err: unknown) {
  showAlertDialog(this, {
    title: this.hass.localize("ui.panel.config.thread.otbr_config_failed"),
    text: (err as Error).message,
  });
  // Log error or handle specific error cases here
}

Tools

Biome

[error] 533-533: Unexpected any. Specify a different type. (lint/suspicious/noExplicitAny)

any disables many type checking rules. Its use should be avoided.

---

Line range hint 654-654: Specify a more accurate type than any for ev.

Using any reduces type safety. Consider specifying a more accurate type for better type checking and maintainability.

- const dataset = (ev.currentTarget as any).networkDataset as ThreadDataSet;
+ const dataset = (ev.currentTarget as HTMLElement).networkDataset as ThreadDataSet;

src/panels/config/integrations/integration-panels/thread/thread-config-panel.ts (2)

Line range hint 211-254: Complex logic in _renderNetwork needs refactoring.

The function _renderNetwork contains complex logic to determine the OTBR for a network. Consider refactoring to reduce complexity and improve maintainability.

- const otbr = this._otbrInfo && this._otbrInfo[router.extended_address];
- const showOverflow = ("dataset" in network && router.border_agent_id) || otbr;
+ const otbr = this._otbrInfo?.[router.extended_address];
+ const showOverflow = network.dataset && router.border_agent_id || otbr;

Tools

Biome

[error] 212-212: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 210-210: Excessive complexity detected.

Please refactor this function to reduce its complexity score from 31 to the max allowed complexity 15.

(lint/complexity/noExcessiveCognitiveComplexity)

---

Line range hint 471-497: Specify a more accurate type than any for event handling and improve error handling in border router methods.

Using any reduces type safety. Consider specifying a more accurate type for better type checking and maintainability. Also, add specific error handling for the API call in _resetBorderRouter.

- const otbr = (ev.currentTarget as any).otbr as OTBRInfo;
+ const otbr = (ev.currentTarget as HTMLElement).otbr as OTBRInfo || null;
if (!otbr) {
  return;
}
try {
  await OTBRCreateNetwork(this.hass, otbr.extended_address);
} catch (err: any) {
  showAlertDialog(this, {
    title: this.hass.localize("ui.panel.config.thread.otbr_config_failed"),
    text: err.message,
  });
  // Log error or handle specific error cases here
}

Tools

Biome

[error] 478-478: Forbidden non-null assertion.

(lint/style/noNonNullAssertion)

---

[error] 493-493: Unexpected any. Specify a different type.

any disables many type checking rules. Its use should be avoided.

(lint/suspicious/noExplicitAny)

src/panels/config/integrations/integration-panels/thread/thread-config-panel.ts (4)

Line range hint 211-254: Refactor: Improve OTBR Handling in Router Display

When displaying routers, the code retrieves OTBR information based on the router's extended address. This could be simplified and made safer with optional chaining.

- this._otbrInfo && this._otbrInfo[router.extended_address];
+ this._otbrInfo?.[router.extended_address];

This change ensures that the code does not break if _otbrInfo is undefined.

Tools

Biome

[error] 212-212: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

Line range hint 471-487: Type Safety and Error Handling in Router Action Handling

The _handleRouterAction method uses type assertions that can be improved for better type safety. Additionally, error handling could be enhanced.

- const otbr = (ev.currentTarget as any).otbr as OTBRInfo;
+ const otbr = (ev.currentTarget as HTMLElement).otbr as OTBRInfo;
if (!otbr) {
  return;
}

This change ensures that the method does not proceed if otbr is undefined, preventing potential runtime errors.

---

Line range hint 492-510: Error Handling in Border Router Reset

The _resetBorderRouter method lacks specific error handling for the API call. Adding detailed error handling can improve user experience and debuggability.

try {
  await OTBRCreateNetwork(this.hass, otbr.extended_address);
} catch (err: any) {
  showAlertDialog(this, {
    title: this.hass.localize("ui.panel.config.thread.otbr_config_failed"),
    text: err.message,
  });
+ // Log error or handle specific error cases here
}

Adding comments or specific error handling strategies can help maintain and debug this method more effectively.

---

Line range hint 618-650: Channel Change Validation and Error Handling

The _changeChannel method allows for changing the communication channel of an OTBR. This method could benefit from additional validations and error handling to ensure the channel number is within the valid range before making the API call.

const channel = parseInt(channelStr);
+ if (channel < 11 || channel > 26) {
+   showAlertDialog(this, {
+     title: this.hass.localize("ui.panel.config.thread.change_channel_invalid"),
+     text: this.hass.localize("ui.panel.config.thread.change_channel_range"),
+   });
+   return;
+ }
try {
  const result = await OTBRSetChannel(this.hass, otbr.extended_address, channel);
  showAlertDialog(this, {
    title: this.hass.localize("ui.panel.config.thread.change_channel_initiated_title"),
    text: this.hass.localize("ui.panel.config.thread.change_channel_initiated_text", { delay: Math.floor(result.delay / 60) }),
  });
} catch (err: any) {
  showAlertDialog(this, {
    title: "Error",
    text: err.message || err,
  });
}

This change ensures that invalid channel numbers are caught early, preventing unnecessary API calls and potential errors.